Defer Emscripten window events during a frame#183
Open
relh wants to merge 1 commit into
Open
Conversation
Focus and resize events can arrive while Asyncify has suspended onFrame. Queue those callbacks until onFrame returns so window state changes at a frame boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Focus, blur, and resize events that arrive while Asyncify has suspended
onFrameare queued until the frame returns. This keeps window callbacks from changing state in the middle of a frame.Check
nim c -d:emscripten examples/basic.nimwith Emscripten 6.0.2